hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16699) Overflows in AverageIntervalRateLimiter's refill() and getWaitInterval()
Date Tue, 11 Oct 2016 01:40:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15564129#comment-15564129
] 

Hudson commented on HBASE-16699:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #35 (See [https://builds.apache.org/job/HBase-1.3-JDK7/35/])
HBASE-16699 Overflows in AverageIntervalRateLimiter's refill() and (matteo.bertozzi: rev 387a08657c06e350e3d912e98486c8ae3a1fe025)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/NoopOperationQuota.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/OperationQuota.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RateLimiter.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/DefaultOperationQuota.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaLimiter.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/NoopQuotaLimiter.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestRateLimiter.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/AverageIntervalRateLimiter.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/TimeBasedLimiter.java


> Overflows in AverageIntervalRateLimiter's refill() and getWaitInterval()
> ------------------------------------------------------------------------
>
>                 Key: HBASE-16699
>                 URL: https://issues.apache.org/jira/browse/HBASE-16699
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 1.4.0
>            Reporter: huaxiang sun
>            Assignee: huaxiang sun
>             Fix For: 2.0.0, 1.3.0, 1.4.0, 1.2.5, 1.1.8
>
>         Attachments: HBASE-16699.branch-1.001.patch, HBASE-16699.master.001.patch, HBASE-16699.master.002.patch
>
>
> It seems that there are more overflow in other places, and a concurrent issue.
> I will post a patch within one or 2 days after I figure out adding new unittest cases.
> Please see the following two lines. Once it overflows, it will cause wrong behavior.
For unconfigured RateLimiters, we should have simpler logic to byPass the check. 
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/AverageIntervalRateLimiter.java#L37
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/AverageIntervalRateLimiter.java#L51



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message