hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Heng Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken
Date Sat, 08 Oct 2016 03:20:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15557043#comment-15557043

Heng Chen commented on HBASE-16664:

It is ok, but not graceful. "1" will be a magic code.
Yes, please add some comments about it,  it is really hard to understand, but the bug should
be fixed. 

I think we can keep two kinds of tracker logic now(in RetryingTimeTracker and CancellableRegionServerCallable),
and finally we can merge them into AsyncTable's implementation.
Please don't do it.  This issue is for bug fix,  we should not introduce other issues which
will be fixed in future.

> Timeout logic in AsyncProcess is broken
> ---------------------------------------
>                 Key: HBASE-16664
>                 URL: https://issues.apache.org/jira/browse/HBASE-16664
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Phil Yang
>            Assignee: Phil Yang
>         Attachments: 1.patch, HBASE-16664-v1.patch, HBASE-16664-v2.patch, testhcm.patch
> Have not checked the root cause, but I think timeout of all operations in AsyncProcess
is broken

This message was sent by Atlassian JIRA

View raw message