hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Yang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken
Date Tue, 04 Oct 2016 14:22:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545472#comment-15545472
] 

Phil Yang commented on HBASE-16664:
-----------------------------------

{quote}
Now we use remaining==0 to check whether the timeout is reached, change it to be <= 1?
{quote}
It is ok, but not graceful. "1" will be a magic code. And we may merge all Table operations
into one implementation(AsnycTable) in future, then RetryingTimeTracker or a similar one will
be called in only one place. I think we can keep two kinds of tracker logic now(in RetryingTimeTracker
and CancellableRegionServerCallable), and finally we can merge them into AsyncTable's implementation.

> Timeout logic in AsyncProcess is broken
> ---------------------------------------
>
>                 Key: HBASE-16664
>                 URL: https://issues.apache.org/jira/browse/HBASE-16664
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Phil Yang
>            Assignee: Phil Yang
>         Attachments: 1.patch, HBASE-16664-v1.patch, HBASE-16664-v2.patch, testhcm.patch
>
>
> Have not checked the root cause, but I think timeout of all operations in AsyncProcess
is broken



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message