hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12894) Upgrade Jetty to 9.2.6
Date Tue, 11 Oct 2016 21:19:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15566640#comment-15566640
] 

stack commented on HBASE-12894:
-------------------------------

We had a reference to jetty in hbase-common? Thats crazy.

Suggest these defines go into the REST module rather than up into HConstants. They are only
used in REST module? If so, yeah, keep them local:

57	  String REST_SSL_EXCLUDE_CIPHER_SUITES = "hbase.rest.ssl.exclude.cipher.suites";
58	  String REST_SSL_INCLUDE_CIPHER_SUITES = "hbase.rest.ssl.include.cipher.suites";
59	  String REST_SSL_EXCLUDE_PROTOCOLS = "hbase.rest.ssl.exclude.protocols";
60	  String REST_SSL_INCLUDE_PROTOCOLS = "hbase.rest.ssl.include.protocols";
61	
62	  String REST_THREAD_POOL_THREADS_MAX = "hbase.rest.threads.max";
63	  String REST_THREAD_POOL_THREADS_MIN = "hbase.rest.threads.min";
64	  String REST_THREAD_POOL_TASK_QUEUE_SIZE = "hbase.rest.task.queue.size";
65	  String REST_THREAD_POOL_THREAD_IDLE_TIMEOUT = "hbase.rest.thread.idle.timeout";
66	  String REST_CONNECTOR_ACCEPT_QUEUE_SIZE = "hbase.rest.connector.accept.queue.size";


How is this provided now? JacksonProvider.java

Skimmed.

Patch looks really good.

Do we need to shade jetty? If an old jetty on our CLASSPATH, we going to get messed up?

Thanks [~yguang11]

> Upgrade Jetty to 9.2.6
> ----------------------
>
>                 Key: HBASE-12894
>                 URL: https://issues.apache.org/jira/browse/HBASE-12894
>             Project: HBase
>          Issue Type: Improvement
>          Components: REST
>    Affects Versions: 0.98.0
>            Reporter: Rick Hallihan
>            Assignee: Guang Yang
>              Labels: MicrosoftSupport
>             Fix For: 2.0.0
>
>         Attachments: HBASE-12894_Jetty9_v0.patch, HBASE-12894_Jetty9_v1.patch
>
>
> The Jetty component that is used for the HBase Stargate REST endpoint is version 6.1.26
and is fairly outdated. We recently had a customer inquire about enabling cross-origin resource
sharing (CORS) for the REST endpoint and found that this older version does not include the
necessary filter or configuration options, highlighted at: http://wiki.eclipse.org/Jetty/Feature/Cross_Origin_Filter
> The Jetty project has had significant updates through versions 7, 8 and 9, including
a transition to be an Eclipse subproject, so updating to the latest version may be non-trivial.
The last update to the Jetty component in https://issues.apache.org/jira/browse/HBASE-3377
was a minor version update and did not require significant work. This update will include
a package namespace update so there will likely be a larger number of required changes. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message