hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11354) HConnectionImplementation#DelayedClosing does not start
Date Tue, 04 Oct 2016 23:52:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15547092#comment-15547092
] 

Lars Hofhansl commented on HBASE-11354:
---------------------------------------

bq. Threads.setDaemonThreadRunning

Cool. Thanks for looking.

After the 5 minute look close to midnight, I wasn't quite sure whether that's the right thing
to do or not, as it seems (going by the name) the reason for this thread running is to delay
the closing of the connection, which it won't if the JVM is shut-down and it is a daemon thread.


> HConnectionImplementation#DelayedClosing does not start
> -------------------------------------------------------
>
>                 Key: HBASE-11354
>                 URL: https://issues.apache.org/jira/browse/HBASE-11354
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.99.0, 0.98.3
>            Reporter: Qianxi Zhang
>            Assignee: Qianxi Zhang
>            Priority: Minor
>             Fix For: 0.98.23
>
>         Attachments: HBASE-11354-0.98.addendum.patch, HBASE-11354-0.98.patch, HBASE_11354
(1).patch, HBASE_11354.patch, HBASE_11354.patch, HBASE_11354.patch
>
>
> The method "createAndStart" in class DelayedClosing only creates a instance, but forgets
to start it. So thread delayedClosing is not running all the time.
> ConnectionManager#1623
> {code}
>       static DelayedClosing createAndStart(HConnectionImplementation hci){
>         Stoppable stoppable = new Stoppable() {
>               private volatile boolean isStopped = false;
>               @Override public void stop(String why) { isStopped = true;}
>               @Override public boolean isStopped() {return isStopped;}
>             };
>         return new DelayedClosing(hci, stoppable);
>       }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message