Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DFF0C200B8D for ; Fri, 23 Sep 2016 21:55:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id DE7ED160AD6; Fri, 23 Sep 2016 19:55:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 301A9160ACF for ; Fri, 23 Sep 2016 21:55:22 +0200 (CEST) Received: (qmail 4957 invoked by uid 500); 23 Sep 2016 19:55:21 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 4930 invoked by uid 99); 23 Sep 2016 19:55:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Sep 2016 19:55:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 36E872C0B08 for ; Fri, 23 Sep 2016 19:55:21 +0000 (UTC) Date: Fri, 23 Sep 2016 19:55:21 +0000 (UTC) From: "Yu Li (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-16698) Performance issue: handlers stuck waiting for CountDownLatch inside WALKey#getWriteEntry under high writing workload MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 23 Sep 2016 19:55:23 -0000 [ https://issues.apache.org/jira/browse/HBASE-16698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li updated HBASE-16698: -------------------------- Summary: Performance issue: handlers stuck waiting for CountDownLatch inside WALKey#getWriteEntry under high writing workload (was: Handlers stuck waiting for CountDownLatch inside WALKey#getWriteEntry under high writing workload) > Performance issue: handlers stuck waiting for CountDownLatch inside WALKey#getWriteEntry under high writing workload > -------------------------------------------------------------------------------------------------------------------- > > Key: HBASE-16698 > URL: https://issues.apache.org/jira/browse/HBASE-16698 > Project: HBase > Issue Type: Improvement > Components: Performance > Affects Versions: 1.1.6, 1.2.3 > Reporter: Yu Li > Assignee: Yu Li > > As titled, on our production environment we observed 98 out of 128 handlers get stuck waiting for the CountDownLatch {{seqNumAssignedLatch}} inside {{WALKey#getWriteEntry}} under a high writing workload. > After digging into the problem, we found that the problem is mainly caused by advancing mvcc in the append logic. Below is some detailed analysis: > Under current branch-1 code logic, all batch puts will call {{WALKey#getWriteEntry}} after appending edit to WAL, and {{seqNumAssignedLatch}} is only released when the relative append call is handled by RingBufferEventHandler (see {{FSWALEntry#stampRegionSequenceId}}). Because currently we're using a single event handler for the ringbuffer, the append calls are handled one by one (actually lot's of our current logic depending on this sequential dealing logic), and this becomes a bottleneck under high writing workload. > The worst part is that by default we only use one WAL per RS, so appends on all regions are dealt with in sequential, which causes contention among different regions... > To fix this, we could also take use of the "sequential appends" mechanism, that we could grab the WriteEntry before publishing append onto ringbuffer and use it as sequence id, only that we need to add a lock to make "grab WriteEntry" and "append edit" a transaction. This will still cause contention inside a region but could avoid contention between different regions. This solution is already verified in our online environment and proved to be effective. > Notice that for master (2.0) branch since we already change the write pipeline to sync before writing memstore (HBASE-15158), this issue only exists for the ASYNC_WAL writes scenario. -- This message was sent by Atlassian JIRA (v6.3.4#6332)