Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2FA02200B90 for ; Sun, 25 Sep 2016 18:20:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2E1CF160ACE; Sun, 25 Sep 2016 16:20:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 998DC160ABE for ; Sun, 25 Sep 2016 18:20:21 +0200 (CEST) Received: (qmail 80220 invoked by uid 500); 25 Sep 2016 16:20:20 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 80201 invoked by uid 99); 25 Sep 2016 16:20:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 25 Sep 2016 16:20:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 8F6792C0B04 for ; Sun, 25 Sep 2016 16:20:20 +0000 (UTC) Date: Sun, 25 Sep 2016 16:20:20 +0000 (UTC) From: "Yu Li (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-16692) Make ByteBufferUtils#equals safer and correct MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 25 Sep 2016 16:20:22 -0000 [ https://issues.apache.org/jira/browse/HBASE-16692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15521058#comment-15521058 ] Yu Li commented on HBASE-16692: ------------------------------- oops, my bad, was looking into branch-1... Thanks for the confirmation sir. > Make ByteBufferUtils#equals safer and correct > --------------------------------------------- > > Key: HBASE-16692 > URL: https://issues.apache.org/jira/browse/HBASE-16692 > Project: HBase > Issue Type: Improvement > Reporter: binlijin > Assignee: binlijin > Fix For: 2.0.0 > > Attachments: HBASE-16692-master.patch, HBASE-16692-master_v2.patch, HBASE-16692-master_v3.patch, HBASE-16692-master_v4.patch, HBASE-16692-master_v5.patch > > > ByteBufferUtils.equals(HConstants.EMPTY_BYTE_BUFFER, 0, 0, HConstants.EMPTY_BYTE_ARRAY, 0, 0) will throw java.lang.ArrayIndexOutOfBoundsException: -1, i think it should return true. -- This message was sent by Atlassian JIRA (v6.3.4#6332)