Return-Path: <issues-return-260578-archive-asf-public=cust-asf.ponee.io@hbase.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 1B3E7200B89
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed, 21 Sep 2016 10:49:22 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 19E9C160AE2; Wed, 21 Sep 2016 08:49:22 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 812D6160ACF
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 21 Sep 2016 10:49:21 +0200 (CEST)
Received: (qmail 83005 invoked by uid 500); 21 Sep 2016 08:49:20 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 82985 invoked by uid 99); 21 Sep 2016 08:49:20 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Sep 2016 08:49:20 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 792312C2A61
	for <issues@hbase.apache.org>; Wed, 21 Sep 2016 08:49:20 +0000 (UTC)
Date: Wed, 21 Sep 2016 08:49:20 +0000 (UTC)
From: "Heng Chen (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13006411.1474442902000.624785.1474447760493@Atlassian.JIRA>
In-Reply-To: <JIRA.13006411.1474442902000@Atlassian.JIRA>
References: <JIRA.13006411.1474442902000@Atlassian.JIRA> <JIRA.13006411.1474442902133@arcas>
Subject: [jira] [Commented] (HBASE-16665) Check whether
 KeyValueUtil.createXXX could be replaced by CellUtil without copy
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Wed, 21 Sep 2016 08:49:22 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509251#comment-15509251 ] 

Heng Chen commented on HBASE-16665:
-----------------------------------

Not sure for the two place whether KeyValueUtil.createFirstOnRow could be replaced. 

{code: title=AbstractMemStore.java}
    Cell firstCell = KeyValueUtil.createFirstOnRow(
        cell.getRowArray(), cell.getRowOffset(), cell.getRowLength(),
        cell.getFamilyArray(), cell.getFamilyOffset(), cell.getFamilyLength(),
        cell.getQualifierArray(), cell.getQualifierOffset(), cell.getQualifierLength());
    SortedSet<Cell> ss = active.tailSet(firstCell);
{code}

{code: title=ScanQueryMatcher.java}
    KeyValue kv = KeyValueUtil.createFirstOnRow(HConstants.EMPTY_BYTE_ARRAY, 0, 0,
      HConstants.EMPTY_BYTE_ARRAY, 0, 0, bytes, offset, length);
    MatchCode matchCode = columnTracker.checkColumn(kv, type);
    if (matchCode == MatchCode.INCLUDE) {
      return columnTracker.checkVersions(kv, ttl, type, ignoreCount);
    }
    return matchCode;
{code}

> Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-16665
>                 URL: https://issues.apache.org/jira/browse/HBASE-16665
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Heng Chen
>         Attachments: HBASE-16665.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)