Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sun, 18 Sep 2016 03:49:20 +0000 (UTC)
From: "Charlie Qiangeng Xu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13004565.1473767184000.598175.1474170560739@Atlassian.JIRA>
In-Reply-To: <JIRA.13004565.1473767184000@Atlassian.JIRA>
References: <JIRA.13004565.1473767184000@Atlassian.JIRA> <JIRA.13004565.1473767184950@arcas>
Subject: [jira] [Commented] (HBASE-16626) User customized RegionScanner from
 1.X is incompatible with 2.0.0's off-heap part
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 18 Sep 2016 03:49:23 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15500183#comment-15500183 ] 

Charlie Qiangeng Xu commented on HBASE-16626:
---------------------------------------------

First patch in community! Thank you Anoop and all others, you guys are very supportive and responsive :)

> User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-16626
>                 URL: https://issues.apache.org/jira/browse/HBASE-16626
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Offheaping
>    Affects Versions: 2.0.0
>            Reporter: Charlie Qiangeng Xu
>            Assignee: Charlie Qiangeng Xu
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16626-v1.patch
>
>
> Introduced by 2.0.0's off-heap feature, the interface RegionScanner extends a new interface Shipper which contains a  "shipped()" method. 
> In our case, some application user defined customized scanner that implements Interface RegionScanner in 1.X . 
> After we back ported the Off Heap feature of 2.0.0, RegionScannerShippedCallBack throws a "java.lang.AbstractMethodError" when executing scanner.shipped(). It is because the customized scanner didn't override the shipped method yet.
> Instead of forcing every user to add a empty implementation(if they don't really need to scan the file or the RS don't use L2 cache, they don't need to do anything in shipped method) , adding a default method of shipped in Interface  RegionScanner might be a better way.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)