Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 6 Sep 2016 23:41:20 +0000 (UTC)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13003078.1473204749000.502625.1473205280428@Atlassian.JIRA>
In-Reply-To: <JIRA.13003078.1473204749000@Atlassian.JIRA>
References: <JIRA.13003078.1473204749000@Atlassian.JIRA> <JIRA.13003078.1473204749804@arcas>
Subject: [jira] [Updated] (HBASE-16567) Upgrade to protobuf3
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 06 Sep 2016 23:41:22 -0000


     [ https://issues.apache.org/jira/browse/HBASE-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-16567:
--------------------------
    Attachment: HBASE-16567.master.001.patch

> Upgrade to protobuf3
> --------------------
>
>                 Key: HBASE-16567
>                 URL: https://issues.apache.org/jira/browse/HBASE-16567
>             Project: HBase
>          Issue Type: Task
>          Components: Protobufs
>    Affects Versions: 2.0.0
>            Reporter: stack
>            Assignee: stack
>            Priority: Critical
>         Attachments: HBASE-16567.master.001.patch
>
>
> Move master branch on to protobuf3. See https://github.com/google/protobuf/releases We'd do it because pb3 saves some on byte copies can work with offheap buffers -- needed for the off-heap write path project -- thought read-time is still a TODO.
> HBASE-15638 has us first shading protobufs before upgrading. Let us list here issues just going to pb3 without shading if only for completeness sake; i.e. do we have to shade?
>  * pb3 is by default wire compatible with pb2.
>  * protoc3 run against our .protos works fine except pb3 breaks our HBaseZeroCopyLiteralByteString hack.
>  * Starting up a cluster that is all pb3'd seems to work fine.
>  * A pb2 branch-1 can read and write against the pb3 master cluster.
> What will break if we just upgrade to pb3?
>  * We should be able to write HDFS messages on our AsyncWAL using pb3; the pb2 HDFS should be able to  read them (not tested). Or maybe not. See policy here: https://github.com/google/protobuf/issues/1852
>  * Core Coprocessor Endpoints such as AccessControl seem to just work (their protos will have been protoc3'd). I did simple test with a server from master branch up on pb3 and then going against it with a branch-1 client on pb2. I was able to add grants.
>  * For non-core CPEPs where the protos are pb2 still, it might just work. To test. It would not be the end-of-the-world if they did not.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)