Return-Path: <issues-return-258588-archive-asf-public=cust-asf.ponee.io@hbase.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id CAF46200B7A
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon,  5 Sep 2016 19:39:22 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id C95C1160ABC; Mon,  5 Sep 2016 17:39:22 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 1219F160AB0
	for <archive-asf-public@cust-asf.ponee.io>; Mon,  5 Sep 2016 19:39:21 +0200 (CEST)
Received: (qmail 55202 invoked by uid 500); 5 Sep 2016 17:39:20 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 55179 invoked by uid 99); 5 Sep 2016 17:39:20 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Sep 2016 17:39:20 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id A1C972C1B77
	for <issues@hbase.apache.org>; Mon,  5 Sep 2016 17:39:20 +0000 (UTC)
Date: Mon, 5 Sep 2016 17:39:20 +0000 (UTC)
From: "Yu Li (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12998141.1471511366000.493004.1473097160658@Atlassian.JIRA>
In-Reply-To: <JIRA.12998141.1471511366000@Atlassian.JIRA>
References: <JIRA.12998141.1471511366000@Atlassian.JIRA> <JIRA.12998141.1471511366024@arcas>
Subject: [jira] [Commented] (HBASE-16445) Refactor and reimplement RpcClient
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Mon, 05 Sep 2016 17:39:23 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465465#comment-15465465 ] 

Yu Li commented on HBASE-16445:
-------------------------------

Currently in {{AsyncRpcClient#callMethod}} we have below codes:
{code}
      connection = createRpcChannel(md.getService().getName(), addr, ticket);
      FutureListener<Message> listener = new FutureListener<Message>() {...};
      connection.callMethod(md, param, pcrc.cellScanner(), returnType,
          getMessageConverterWithRpcController(pcrc), null,
          pcrc.getCallTimeout(), pcrc.getPriority())
          .addListener(listener);
{code}
It seems to me that we only call {{RpcCallback#run}} or set exception into PCRC in the listener, but miss the exception handling during connection setup, and IMHO we should do more things in {{AsyncRpcChannel#connect}} listener and failure path inside {{AsyncServerResponseHandler#channelRead0}}.

Please correct me if I'm wrong, and if the issue did exist, maybe we could open another JIRA to track it rather than blocking this one. Thanks.

> Refactor and reimplement RpcClient
> ----------------------------------
>
>                 Key: HBASE-16445
>                 URL: https://issues.apache.org/jira/browse/HBASE-16445
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16445-v1.patch, HBASE-16445-v2.patch, HBASE-16445-v3.patch, HBASE-16445-v4.patch, HBASE-16445.patch
>
>
> There are lots of common logics between RpcClientImpl and AsyncRpcClient. We should have much less code comparing to the current implementations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)