hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16736) Add getter to ResizableBlockCache for max size
Date Fri, 30 Sep 2016 16:09:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15536360#comment-15536360
] 

Ted Yu commented on HBASE-16736:
--------------------------------

bq. In case of CombinedCache why to get from L1 cache alone?

The setMaxSize() method is changing lruCache only. Hence I make getMaxSize() symmetrical to
the setter.

bq. Then do we need L2 size also considered?

This is related to the above aspect where max size doesn't consider off heap size. I think
we should keep the current behavior.

I prefer patch v1.

> Add getter to ResizableBlockCache for max size
> ----------------------------------------------
>
>                 Key: HBASE-16736
>                 URL: https://issues.apache.org/jira/browse/HBASE-16736
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 16736.v1.txt, 16736.v2.txt
>
>
> Currently ResizableBlockCache only has one method for setting max size.
> As more first level cache type is added, we need the ability to retrieve the max size.
> This issue is to add getter to ResizableBlockCache for retrieving max size.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message