hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yu Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16692) Make ByteBufferUtils#equals more safe and correct
Date Fri, 23 Sep 2016 16:02:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15516836#comment-15516836
] 

Yu Li commented on HBASE-16692:
-------------------------------

Yep, seems no good way... but at a second thought, we could further refine the check to below
style:
{code}
    if ((l1 == 0) || (l2 == 0)) {
      // both 0 length, return true, or else false
      return l1 == l2;
    }
{code}

> Make ByteBufferUtils#equals more safe and correct
> -------------------------------------------------
>
>                 Key: HBASE-16692
>                 URL: https://issues.apache.org/jira/browse/HBASE-16692
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: binlijin
>            Assignee: binlijin
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16692-master.patch, HBASE-16692-master_v2.patch, HBASE-16692-master_v3.patch
>
>
> ByteBufferUtils.equals(HConstants.EMPTY_BYTE_BUFFER, 0, 0, HConstants.EMPTY_BYTE_ARRAY,
0, 0) will throw java.lang.ArrayIndexOutOfBoundsException: -1, i think it should return true.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message