hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yu Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16670) Make RpcServer#processRequest logic more robust
Date Thu, 22 Sep 2016 05:59:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15512286#comment-15512286
] 

Yu Li commented on HBASE-16670:
-------------------------------

I found this incomplete logic when developing async table codes, some mistake lead me to some
logic like calling {{getStub().mutate(controller, null);}}. So in our current codes there
won't be such a kind of request, this is why I set the priority of this JIRA to Minor, but
I think this is still something worth improving. Agree?:-)

> Make RpcServer#processRequest logic more robust
> -----------------------------------------------
>
>                 Key: HBASE-16670
>                 URL: https://issues.apache.org/jira/browse/HBASE-16670
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Yu Li
>            Assignee: Yu Li
>            Priority: Minor
>         Attachments: HBASE-16670.patch
>
>
> Currently in {{RpcServer#processRequest}}, we will check whether the request header has
parameters but missed handling the abnormal case, so if there's no param in the header, it
will throw NPE like below:
> {noformat}
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(java.io.IOException): java.io.IOException
> 	at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2269)
> 	at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123)
> 	at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:189)
> 	at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:169)
> Caused by: java.lang.NullPointerException
> 	at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2211)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message