hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16659) Use CellUtil.createFirstOnRow instead of KeyValueUtil.createFirstOnRow in some places.
Date Wed, 21 Sep 2016 07:23:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509038#comment-15509038
] 

Anoop Sam John commented on HBASE-16659:
----------------------------------------

Go for it. Test fails seems not at all related. Thanks for the find and patch

> Use CellUtil.createFirstOnRow instead of KeyValueUtil.createFirstOnRow in some places.

> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-16659
>                 URL: https://issues.apache.org/jira/browse/HBASE-16659
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: binlijin
>            Assignee: binlijin
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16659-master.patch, HBASE-16659-master_v2.patch, HBASE-16659-master_v2.patch
>
>
> CellUtil.createFirstOnRow is more effective than KeyValueUtil.createFirstOnRow, because
there is no byte[] copy.
> Current in ReversedRegionScannerImpl#nextRow, to get the previous row to seek, it use
KeyValueUtil.createFirstOnRow which will have two copy, the first copy is copy to a tmp byte[],
the second copy is in KeyValue. We can use CellUtil.createFirstOnRow which will have no copy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message