hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-16626) User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part
Date Fri, 16 Sep 2016 06:37:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15495546#comment-15495546
] 

Anoop Sam John edited comment on HBASE-16626 at 9/16/16 6:36 AM:
-----------------------------------------------------------------

It was because of some old force push.. Now I changed my git local commit repo.. Hope it wont
come with later commits from me.  In commit history diff it shows as trivial merge only..
No extra unwanted change any way.
Sorry for this


was (Author: anoop.hbase):
It was because of some old force push.. Now I changed my git local commit repo.. Hope it wont
come with later commits from me.  Sorry for this

> User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-16626
>                 URL: https://issues.apache.org/jira/browse/HBASE-16626
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Offheaping
>    Affects Versions: 2.0.0
>            Reporter: Charlie Qiangeng Xu
>            Assignee: Charlie Qiangeng Xu
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16626-v1.patch
>
>
> Introduced by 2.0.0's off-heap feature, the interface RegionScanner extends a new interface
Shipper which contains a  "shipped()" method. 
> In our case, some application user defined customized scanner that implements Interface
RegionScanner in 1.X . 
> After we back ported the Off Heap feature of 2.0.0, RegionScannerShippedCallBack throws
a "java.lang.AbstractMethodError" when executing scanner.shipped(). It is because the customized
scanner didn't override the shipped method yet.
> Instead of forcing every user to add a empty implementation(if they don't really need
to scan the file or the RS don't use L2 cache, they don't need to do anything in shipped method)
, adding a default method of shipped in Interface  RegionScanner might be a better way.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message