hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-16591) Add a docker file only contains java 8 for running pre commit on master
Date Fri, 09 Sep 2016 23:52:21 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478697#comment-15478697
] 

Duo Zhang edited comment on HBASE-16591 at 9/9/16 11:52 PM:
------------------------------------------------------------

They do not change git branch in the pre-commit jenkins scripts.

After reading and testing yetus, I found that the 'confirm git environment' is happened before
we setup the docker image. The only thing is that I need to add a ' --resetrepo ' options
otherwise yetus will not try to checkout the correct branch. Seems ' --jenkins ' could also
work so it is fine. So I think we could left the docker file empty for branch other than master
to let them use default docker image of yetus?

Let me prepare the docker file patch.

Thanks.


was (Author: apache9):
They do not change git branch in the pre-commit jenkins scripts.

After reading and testing yetus, I found that the 'confirm git environment' is happened before
we setup the docker image. The only thing is that I need to add a '--resetrepo' options otherwise
yetus will not try to checkout the correct branch. Seems '--jenkins' could also work so it
is fine. So I think we could left the docker file empty for branch other than master to let
them use default docker image of yetus?

Let me prepare the docker file patch.

Thanks.

> Add a docker file only contains java 8 for running pre commit on master
> -----------------------------------------------------------------------
>
>                 Key: HBASE-16591
>                 URL: https://issues.apache.org/jira/browse/HBASE-16591
>             Project: HBase
>          Issue Type: Task
>          Components: build
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Blocker
>             Fix For: 2.0.0
>
>
> As described in YETUS-369, this is a workaround before YETUS-369 done. Hadoop's pre-commit
has already been java 8 only, so I think we could just copy their docker file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message