hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Yuan Jiang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16587) Procedure v2 - Cleanup suspended proc execution
Date Wed, 21 Sep 2016 03:00:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15508530#comment-15508530
] 

Stephen Yuan Jiang commented on HBASE-16587:
--------------------------------------------

[~mbertozzi], could you put the patch into RB for easy code review?  

For V3 patch, I don't see your override the newly added holdLock() and hasLock() in the test
procedure.  (the logic of checking both holdLock() and hasLock() seems over complicated, but
I have not see an issue here)

> Procedure v2 - Cleanup suspended proc execution
> -----------------------------------------------
>
>                 Key: HBASE-16587
>                 URL: https://issues.apache.org/jira/browse/HBASE-16587
>             Project: HBase
>          Issue Type: Sub-task
>          Components: proc-v2
>    Affects Versions: 2.0.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16587-v0.patch, HBASE-16587-v1.patch, HBASE-16587-v2.patch,
HBASE-16587-v3.patch
>
>
> for procedures like the assignment or the lock one we need to be able to hold on locks
while suspended. At the moment the way to do that is up to the proc implementation. This patch
moves the logic to the base Procedure and ProcedureExecutor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message