hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "binlijin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16570) Compute region locality in parallel at startup
Date Thu, 08 Sep 2016 09:39:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15473389#comment-15473389
] 

binlijin commented on HBASE-16570:
----------------------------------

{quote}
The future could be null? It seems that the asyncGetBlockDistribution always return one Object
due to you catch all exceptions
{quote}
This will be null in TestBaseLoadBalancer#testClusterRegionLocations, because the RegionLocationFinder
is mocked.
{code}
    // mock block locality for some regions
    RegionLocationFinder locationFinder = mock(RegionLocationFinder.class);
{code}

{quote}
By the way, {{new HDFSBlocksDistribution() }} could be replaced by EMPTY_BLOCK_DISTRIBUTION
?
{quote}
OK, will change it.

{quote}
It could be removed, it seems no reference to the method.
{quote}
Ok.
{quote}
Besides that, the patch looks good, could it accelerate the startup? Do you have some numbers
about it?
{quote}
I do not test it, because this is complement for  HBASE-14473.



> Compute region locality in parallel at startup
> ----------------------------------------------
>
>                 Key: HBASE-16570
>                 URL: https://issues.apache.org/jira/browse/HBASE-16570
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: binlijin
>            Assignee: binlijin
>         Attachments: HBASE-16570-master_V1.patch, HBASE-16570-master_V2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message