hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16567) Upgrade to protobuf-3.1.x
Date Thu, 29 Sep 2016 22:54:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15534332#comment-15534332
] 

Hadoop QA commented on HBASE-16567:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {color} | {color:blue}
Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s {color} | {color:red}
HBASE-16567 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.3.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12831015/16567.patch |
| JIRA Issue | HBASE-16567 |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/3775/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> Upgrade to protobuf-3.1.x
> -------------------------
>
>                 Key: HBASE-16567
>                 URL: https://issues.apache.org/jira/browse/HBASE-16567
>             Project: HBase
>          Issue Type: Task
>          Components: Protobufs
>    Affects Versions: 2.0.0
>            Reporter: stack
>            Assignee: stack
>            Priority: Critical
>         Attachments: 16567.patch, HBASE-16567.master.001.patch
>
>
> Move master branch on to protobuf3. See https://github.com/google/protobuf/releases We'd
do it because pb3 saves some on byte copies can work with offheap buffers -- needed for the
off-heap write path project -- though read-time is still a TODO (this means pb3 is not enough;
we'll have to patch it -- or patch pb2.5).
> HBASE-15638 has us first shading protobufs before upgrading. Let us list here issues
just going to pb3 without shading if only for completeness sake; i.e. do we have to shade?
>  * pb3 is by default wire compatible with pb2.
>  * protoc3 run against our .protos works fine except pb3 breaks our HBaseZeroCopyLiteralByteString
hack so this has to be removed (possibly recast using new pb3 types)
>  * Starting up a cluster that is all pb3 seems to work fine.
>  * A pb2 branch-1 can read and write against the pb3 master cluster.
> What will break if we just upgrade to pb3?
>  * We should be able to write HDFS messages on our AsyncWAL using pb3; the pb2 HDFS should
be able to  read them (not tested). Or maybe not. See policy here: https://github.com/google/protobuf/issues/1852
which seems to indicate pb3s will not be able to write compatible pb2 Messages. TODO.
>  * Core Coprocessor Endpoints such as AccessControl seem to just work (their protos will
have been protoc3'd). I did simple test with a server from master branch up on pb3 and then
going against it with a branch-1 client on pb2. I was able to add grants.
>  * For non-core CPEPs where the protos are pb2 still, it might just work. To test. It
would not be the end-of-the-world if they did not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message