hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yu Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16505) Add AsyncRegion interface to pass deadline and support async operations
Date Mon, 05 Sep 2016 06:43:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464253#comment-15464253
] 

Yu Li commented on HBASE-16505:
-------------------------------

bq. getResult can not break by notifyAll, we need another way...
One possible way is to notifyAll when {{reset}} is called, and throw an IOE if {{getResults}}
exits the while loop with both {{result}} and {{exception}} set to null, like
{code}
    if (exception != null) {
      if (exception instanceof IOException) {
        throw (IOException)exception;
      }
      throw (TimeoutException)exception;
    }
+  if (result == null) {
+    throw new IOException(
+        "Both exception and result set to null, context is probably reset while waiting for
the result");
+  }
{code}

bq. And it seems that new HBaseRpcController interface can do the same thing, let me see if
we can use HBaseRpcController directly
Sure, better if we could reuse some existing codes. Will wait for your next patch anyway.
:-)

> Add AsyncRegion interface to pass deadline and support async operations
> -----------------------------------------------------------------------
>
>                 Key: HBASE-16505
>                 URL: https://issues.apache.org/jira/browse/HBASE-16505
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Phil Yang
>            Assignee: Phil Yang
>         Attachments: HBASE-16505-v1.patch, HBASE-16505-v2.patch, HBASE-16505-v3.patch,
HBASE-16505-v4.patch
>
>
> If we want to know the correct setting of timeout in read/write path, we need add a new
parameter in operation-methods of Region.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message