hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16460) Can't rebuild the BucketAllocator's data structures when BucketCache use FileIOEngine
Date Fri, 02 Sep 2016 21:24:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15459632#comment-15459632
] 

Ted Yu commented on HBASE-16460:
--------------------------------

{code}
405	      LOG.warn("There are " + sizeNotMatchedCount + " blocks which can't rebuild because
",
406	        new BucketAllocatorException("Can't match bucket size for these blocks"));
{code}
Looks like the BucketAllocatorException wouldn't provide much information. Just append the
second message to the first - that way we don't need BucketAllocatorException.
Same comment applies to the next warning log.

> Can't rebuild the BucketAllocator's data structures when BucketCache use FileIOEngine
> -------------------------------------------------------------------------------------
>
>                 Key: HBASE-16460
>                 URL: https://issues.apache.org/jira/browse/HBASE-16460
>             Project: HBase
>          Issue Type: Bug
>          Components: BucketCache
>    Affects Versions: 2.0.0, 1.1.6, 1.3.1, 1.2.3, 0.98.22
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>         Attachments: HBASE-16460-v1.patch, HBASE-16460-v2.patch, HBASE-16460-v2.patch,
HBASE-16460-v3.patch, HBASE-16460-v4.patch, HBASE-16460-v5.patch, HBASE-16460-v5.patch, HBASE-16460.patch
>
>
> When bucket cache use FileIOEngine, it will rebuild the bucket allocator's data structures
from a persisted map. So it should first read the map from persistence file then use the map
to new a BucketAllocator. But now the code has wrong sequence in retrieveFromFile() method
of BucketCache.java.
> {code}
>       BucketAllocator allocator = new BucketAllocator(cacheCapacity, bucketSizes, backingMap,
realCacheSize);
>       backingMap = (ConcurrentHashMap<BlockCacheKey, BucketEntry>) ois.readObject();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message