hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-16373) precommit needs a dockerfile with hbase prereqs
Date Thu, 29 Sep 2016 17:12:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15533356#comment-15533356
] 

Sean Busbey edited comment on HBASE-16373 at 9/29/16 5:11 PM:
--------------------------------------------------------------

It's the section that starts right after this comment:

{code}
#
# Yetus *always* builds with JAVA_HOME, so no need to list it.
#
# non-docker-mode JDK:
#         --findbugs-home=/home/jenkins/tools/findbugs/latest \
#         --multijdkdirs="${TOOLS_HOME}/java/jdk1.8.0" \

# docker-mode:  (openjdk 7 added for free)
#         --findbugs-home=/opt/findbugs \
#         --docker \
#         --multijdkdirs="/usr/lib/jvm/java-8-oracle" \
{code}

Essentially, we set JAVA_HOME to jdk7 and then tell yetus where jdk8 is.


was (Author: busbey):
It's the section that starts right after this comment:

{quote}
#
# Yetus *always* builds with JAVA_HOME, so no need to list it.
#
# non-docker-mode JDK:
#         --findbugs-home=/home/jenkins/tools/findbugs/latest \
#         --multijdkdirs="${TOOLS_HOME}/java/jdk1.8.0" \

# docker-mode:  (openjdk 7 added for free)
#         --findbugs-home=/opt/findbugs \
#         --docker \
#         --multijdkdirs="/usr/lib/jvm/java-8-oracle" \
{quote}

Essentially, we set JAVA_HOME to jdk7 and then tell yetus where jdk8 is.

> precommit needs a dockerfile with hbase prereqs
> -----------------------------------------------
>
>                 Key: HBASE-16373
>                 URL: https://issues.apache.org/jira/browse/HBASE-16373
>             Project: HBase
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.3.0, 1.4.0, 1.1.6, 1.2.3, 0.98.22
>            Reporter: Sean Busbey
>            Assignee: Duo Zhang
>            Priority: Critical
>             Fix For: 1.3.0, 1.4.0, 1.1.7, 0.98.23, 1.2.4
>
>         Attachments: HBASE-16373-branch-1.patch
>
>
> specifically, we need protoc. starting with the dockerfile used by default in yetus and
adding it will probably suffice.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message