hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Helmling (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16146) Counters are expensive...
Date Sat, 24 Sep 2016 00:38:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15518004#comment-15518004
] 

Gary Helmling commented on HBASE-16146:
---------------------------------------

In master, where we can rely on LongAdder, we've already replaced Counter with that.

In branch-1, I'm not sure that using reflection to call through to LongAdder when running
on Java 8 is going to give us a more performant solution.  And it still won't help the situation
when running on Java < 8.  Besides, Counter generally performs well, it just seems to degrade
as more Counters are kept in memory due to the ThreadLocal usage.

> Counters are expensive...
> -------------------------
>
>                 Key: HBASE-16146
>                 URL: https://issues.apache.org/jira/browse/HBASE-16146
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: stack
>         Attachments: HBASE-16146.branch-1.3.001.patch, counters.patch, less_and_less_counters.png
>
>
> Doing workloadc, perf shows 10%+ of CPU being spent on counter#add. If I disable some
of the hot ones -- see patch -- I can get 10% more throughput (390k to 440k). Figure something
better.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message