hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16134) Introduce Cell extension for server side.
Date Mon, 26 Sep 2016 06:19:21 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522194#comment-15522194
] 

Anoop Sam John commented on HBASE-16134:
----------------------------------------

Am doing a bit of change on the latest patch.  U can see, now the write(OS) method in Cell
will write the total length (4 bytes) followed by the cell itself.  Write of this total length
int should be done by the Codec itself. It is upto the Encoder and decoder to know how they
want to pass the total cell length.  Right now we dont use this write(OS) method while write
the cells to HFiles.  We can infact use that. Only diff is in case of write to HFiles, we
dont write total length of cell where as in case of RPC and WAL, we will first write total
length int.   So my plan is to add an API to retrieve the total cell length also along with
write(OS).  The codec uses this API and writes the int to OS and then call Cell#write()..
The write impl will just write the cell as such into the OS.  Will post the patch today.

> Introduce Cell extension for server side.
> -----------------------------------------
>
>                 Key: HBASE-16134
>                 URL: https://issues.apache.org/jira/browse/HBASE-16134
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16134.patch, HBASE-16134.patch, HBASE-16134_V2.patch
>
>
> Came after the discussion under HBASE-15721 and HBASE-15879.
> InternalCell is a Cell extension. We do have Cell extensions across different interfaces
now.
> SettableSeqId
> SettableTimestamp
> Streamable.
> And demand for this keep growing.
> So let us include everything into one Interface.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message