hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it
Date Fri, 23 Sep 2016 03:28:22 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15515258#comment-15515258
] 

Duo Zhang commented on HBASE-15921:
-----------------------------------

Let's talk about the retry and timeout logic.

In general, I think we should only do retry at one place, which means, we always restart from
the beginning. We can config different timeout values for different stages, but the actual
timeout when executing the operation will also be limited by the whole operation timeout config.
This could simplify our logic. For example, we do not need to implement retry logic in rpc(Yeah
I have just removed the reconnect logic in NettyRpcConnection). And it is also much easier
for us to implement the backoff logic.

What do you think? [~stack] [~carp84] [~chenheng].

Thanks.

> Add first AsyncTable impl and create TableImpl based on it
> ----------------------------------------------------------
>
>                 Key: HBASE-15921
>                 URL: https://issues.apache.org/jira/browse/HBASE-15921
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Jurriaan Mous
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15921-v2.patch, HBASE-15921.demo.patch, HBASE-15921.patch,
HBASE-15921.v1.patch
>
>
> First we create an AsyncTable interface with implementation without the Scan functionality.
Those will land in a separate patch since they need a refactor of existing scans.
> Also added is a new TableImpl to replace HTable. It uses the AsyncTableImpl internally
and should be a bit faster because it does jump through less hoops to do ProtoBuf transportation.
This way we can run all existing tests on the AsyncTableImpl to guarantee its quality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message