Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D977A200B80 for ; Wed, 31 Aug 2016 07:29:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D8129160AC6; Wed, 31 Aug 2016 05:29:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 21842160ABA for ; Wed, 31 Aug 2016 07:29:21 +0200 (CEST) Received: (qmail 39803 invoked by uid 500); 31 Aug 2016 05:29:20 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 39777 invoked by uid 99); 31 Aug 2016 05:29:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Aug 2016 05:29:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id A331B2C1B7B for ; Wed, 31 Aug 2016 05:29:20 +0000 (UTC) Date: Wed, 31 Aug 2016 05:29:20 +0000 (UTC) From: "Anoop Sam John (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-16531) Move cell block related code out of IPCUtil MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 31 Aug 2016 05:29:23 -0000 [ https://issues.apache.org/jira/browse/HBASE-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15451186#comment-15451186 ] Anoop Sam John commented on HBASE-16531: ---------------------------------------- Belated +1. Nice one.. > Move cell block related code out of IPCUtil > ------------------------------------------- > > Key: HBASE-16531 > URL: https://issues.apache.org/jira/browse/HBASE-16531 > Project: HBase > Issue Type: Sub-task > Components: rpc > Affects Versions: 2.0.0 > Reporter: Duo Zhang > Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-16531.patch > > > Creating an instance of an 'Util' class is a little strange. We should move the cell block related code to another class with a better name. IPCUtil should only contain static util methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)