Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 674AE200B80 for ; Wed, 31 Aug 2016 01:23:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 65C2D160AC6; Tue, 30 Aug 2016 23:23:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D4654160AC5 for ; Wed, 31 Aug 2016 01:23:22 +0200 (CEST) Received: (qmail 24404 invoked by uid 500); 30 Aug 2016 23:23:22 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 24322 invoked by uid 99); 30 Aug 2016 23:23:22 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Aug 2016 23:23:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id DA67C2C1B79 for ; Tue, 30 Aug 2016 23:23:21 +0000 (UTC) Date: Tue, 30 Aug 2016 23:23:21 +0000 (UTC) From: "Matteo Bertozzi (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-16528) Procedure-V2: ServerCrashProcedure misses owner information MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 30 Aug 2016 23:23:23 -0000 [ https://issues.apache.org/jira/browse/HBASE-16528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15450459#comment-15450459 ] Matteo Bertozzi commented on HBASE-16528: ----------------------------------------- v2 looks ok, you can just do env.getRequestUser().getShortName() instead of going also to the UGI. any particular reason to not just forcing Superusers.getSystemUser()? only hbase itself triggers the ServerCrashProc > Procedure-V2: ServerCrashProcedure misses owner information > ----------------------------------------------------------- > > Key: HBASE-16528 > URL: https://issues.apache.org/jira/browse/HBASE-16528 > Project: HBase > Issue Type: Bug > Components: hbase, master, proc-v2 > Affects Versions: 2.0.0, 1.1.5 > Reporter: Stephen Yuan Jiang > Assignee: Stephen Yuan Jiang > Attachments: HBASE-16528.v1-master.patch, HBASE-16528.v2-master.patch > > > ServerCrashProcedure constructor does not set up owner information. If someone wants to access the owner of ServerCrashProcedure, it would get NPE (eg. in case someone accidentally tries to abort a ServerCrashProcedure, the coprocessor to check owner of the procedure would throw NPE) -- This message was sent by Atlassian JIRA (v6.3.4#6332)