Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7A19A200B6F for ; Wed, 24 Aug 2016 16:44:24 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 78B71160AB1; Wed, 24 Aug 2016 14:44:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AC391160AC2 for ; Wed, 24 Aug 2016 16:44:23 +0200 (CEST) Received: (qmail 50255 invoked by uid 500); 24 Aug 2016 14:44:22 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 50046 invoked by uid 99); 24 Aug 2016 14:44:22 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Aug 2016 14:44:22 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7AE042C0150 for ; Wed, 24 Aug 2016 14:44:22 +0000 (UTC) Date: Wed, 24 Aug 2016 14:44:22 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-16471) Region Server metrics context will be wrong when machine hostname contain "master" word MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 24 Aug 2016 14:44:24 -0000 [ https://issues.apache.org/jira/browse/HBASE-16471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435038#comment-15435038 ] Hudson commented on HBASE-16471: -------------------------------- FAILURE: Integrated in Jenkins build HBase-1.1-JDK7 #1772 (See [https://builds.apache.org/job/HBase-1.1-JDK7/1772/]) HBASE-16471 Region Server metrics context will be wrong when machine (ashishsinghi: rev 43c93d4c69a490723f176c1e1e4aed181cc6ef85) * (edit) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceFactory.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcMetrics.java > Region Server metrics context will be wrong when machine hostname contain "master" word > --------------------------------------------------------------------------------------- > > Key: HBASE-16471 > URL: https://issues.apache.org/jira/browse/HBASE-16471 > Project: HBase > Issue Type: Bug > Components: metrics > Affects Versions: 2.0.0, 1.3.0, 0.98.21 > Reporter: Pankaj Kumar > Assignee: Pankaj Kumar > Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0, 1.1.6, 1.2.3, 0.98.22 > > Attachments: HBASE-16471-0.98.patch, HBASE-16471-V2.patch, HBASE-16471.patch > > > While initializing RSRpcServices server name is formed as, > {code} > String name = rs.getProcessName() + "/" + initialIsa.toString(); > {code} > So name will be like "regionserver/host_Name/host_IP:port". > During MetricsHBaseServer intializing, we create server context name using String contains() which will be wrong when machine hostname contain "master" words. > In MetricsHBaseServerSourceFactory, > {code} > protected static String createContextName(String serverName) { > if (serverName.contains("HMaster") || serverName.contains("master")) { > return "Master"; > } else if (serverName.contains("HRegion") || serverName.contains("regionserver")) { > return "RegionServer"; > } > return "IPC"; > } > {code} > For example, "regionserver/node-master1-xyz/host-IP:16020" -- This message was sent by Atlassian JIRA (v6.3.4#6332)