Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 24 Aug 2016 13:43:21 +0000 (UTC)
From: "Ashish Singhi (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12999104.1471925391000.397238.1472046201957@Atlassian.JIRA>
In-Reply-To: <JIRA.12999104.1471925391000@Atlassian.JIRA>
References: <JIRA.12999104.1471925391000@Atlassian.JIRA> <JIRA.12999104.1471925391402@arcas>
Subject: [jira] [Updated] (HBASE-16471) Region Server metrics context will
 be wrong when machine hostname contain "master" word
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 24 Aug 2016 13:43:38 -0000


     [ https://issues.apache.org/jira/browse/HBASE-16471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Singhi updated HBASE-16471:
----------------------------------
       Resolution: Fixed
     Hadoop Flags: Reviewed
    Fix Version/s: 0.98.22
                   1.2.3
                   1.1.6
                   1.4.0
                   1.3.0
                   2.0.0
           Status: Resolved  (was: Patch Available)

Checked javadoc errors 0.98 patch Hadoop QA run, nothing related to this jira. Also saw the same output [here|https://issues.apache.org/jira/browse/HBASE-16448?focusedCommentId=15434089&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15434089].

Committed to 0.98+.
Thanks for patch, Pankaj.
Thanks for the review, Ted.

> Region Server metrics context will be wrong when machine hostname contain "master" word
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-16471
>                 URL: https://issues.apache.org/jira/browse/HBASE-16471
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 2.0.0, 1.3.0, 0.98.21
>            Reporter: Pankaj Kumar
>            Assignee: Pankaj Kumar
>            Priority: Minor
>             Fix For: 2.0.0, 1.3.0, 1.4.0, 1.1.6, 1.2.3, 0.98.22
>
>         Attachments: HBASE-16471-0.98.patch, HBASE-16471-V2.patch, HBASE-16471.patch
>
>
> While initializing RSRpcServices server name is formed as,
> {code}
>     String name = rs.getProcessName() + "/" + initialIsa.toString();
> {code}
> So name will be like "regionserver/host_Name/host_IP:port".
> During MetricsHBaseServer intializing, we create server context name using String contains() which will be wrong when machine hostname contain "master" words.
> In MetricsHBaseServerSourceFactory, 
> {code}
>   protected static String createContextName(String serverName) {
>     if (serverName.contains("HMaster") || serverName.contains("master")) {
>       return "Master";
>     } else if (serverName.contains("HRegion") || serverName.contains("regionserver")) {
>       return "RegionServer";
>     }
>     return "IPC";
>   }
> {code}
> For example, "regionserver/node-master1-xyz/host-IP:16020"


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)