Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 22 Aug 2016 07:19:21 +0000 (UTC)
From: "ramkrishna.s.vasudevan (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12998646.1471661941000.367195.1471850361017@Atlassian.JIRA>
In-Reply-To: <JIRA.12998646.1471661941000@Atlassian.JIRA>
References: <JIRA.12998646.1471661941000@Atlassian.JIRA> <JIRA.12998646.1471661941785@arcas>
Subject: [jira] [Commented] (HBASE-16460) Can't rebuild the
 BucketAllocator's data structures when BucketCache use FileIOEngine
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 22 Aug 2016 07:19:23 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430230#comment-15430230 ] 

ramkrishna.s.vasudevan commented on HBASE-16460:
------------------------------------------------

bq.This means over the restart of the RS the bucket sizes (which is configurable by users) should not get changed. If so there is a chance that we will not see a suitable bucket for a block and so we will fail this L2 cache init. We throw Exception!
I think yes. But it seems to be valid correct? Otherwise there is no use of persistence? 

> Can't rebuild the BucketAllocator's data structures when BucketCache use FileIOEngine
> -------------------------------------------------------------------------------------
>
>                 Key: HBASE-16460
>                 URL: https://issues.apache.org/jira/browse/HBASE-16460
>             Project: HBase
>          Issue Type: Bug
>          Components: BucketCache
>    Affects Versions: 2.0.0, 1.1.6, 1.3.1, 1.2.3, 0.98.22
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>         Attachments: HBASE-16460-v1.patch, HBASE-16460.patch
>
>
> When bucket cache use FileIOEngine, it will rebuild the bucket allocator's data structures from a persisted map. So it should first read the map from persistence file then use the map to new a BucketAllocator. But now the code has wrong sequence in retrieveFromFile() method of BucketCache.java.
> {code}
>       BucketAllocator allocator = new BucketAllocator(cacheCapacity, bucketSizes, backingMap, realCacheSize);
>       backingMap = (ConcurrentHashMap<BlockCacheKey, BucketEntry>) ois.readObject();
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)