Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 01E02200B7E for ; Mon, 22 Aug 2016 21:17:25 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 009A1160AB3; Mon, 22 Aug 2016 19:17:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 49618160A87 for ; Mon, 22 Aug 2016 21:17:24 +0200 (CEST) Received: (qmail 81978 invoked by uid 500); 22 Aug 2016 19:17:23 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 81909 invoked by uid 99); 22 Aug 2016 19:17:23 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Aug 2016 19:17:23 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 202832C0150 for ; Mon, 22 Aug 2016 19:17:23 +0000 (UTC) Date: Mon, 22 Aug 2016 19:17:23 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-16459) Remove unused hbase shell --format option MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 22 Aug 2016 19:17:25 -0000 [ https://issues.apache.org/jira/browse/HBASE-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431442#comment-15431442 ] Hadoop QA commented on HBASE-16459: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} rubocop {color} | {color:green} 0m 3s {color} | {color:green} The patch generated 0 new + 31 unchanged - 6 fixed = 31 total (was 37) {color} | | {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green} 0m 2s {color} | {color:green} There were no new ruby-lint issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 26m 43s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m 10s {color} | {color:red} root in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 27m 33s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2016-08-22 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12824905/HBASE-16459_v2.patch | | JIRA Issue | HBASE-16459 | | Optional Tests | asflicense rubocop ruby_lint | | uname | Linux 5ee5b05f4ee6 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / f174fec | | rubocop | v0.42.0 | | ruby-lint | v2.3.0 | | hbaseprotoc | https://builds.apache.org/job/PreCommit-HBASE-Build/3199/artifact/patchprocess/patch-hbaseprotoc-root.txt | | modules | C: . U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/3199/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > Remove unused hbase shell --format option > ----------------------------------------- > > Key: HBASE-16459 > URL: https://issues.apache.org/jira/browse/HBASE-16459 > Project: HBase > Issue Type: Task > Components: shell > Reporter: Dima Spivak > Assignee: Dima Spivak > Priority: Trivial > Labels: beginner > Attachments: HBASE-16459.patch, HBASE-16459_v2.patch > > > The usage information when running {{hbase shell}} refers to a formatter option that has yet to implemented in over 8 years and which will ostensibly never be implemented. As such, let's cleanup the [help message|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L57-L59] and remove some extraneous lines of code from {{[hirb.rb|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L74-L83]}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)