Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C26FE200B7C for ; Wed, 24 Aug 2016 11:22:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C103F160AA4; Wed, 24 Aug 2016 09:22:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1CCCE160AB1 for ; Wed, 24 Aug 2016 11:22:22 +0200 (CEST) Received: (qmail 1305 invoked by uid 500); 24 Aug 2016 09:22:22 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 1048 invoked by uid 99); 24 Aug 2016 09:22:22 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Aug 2016 09:22:22 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 0DB6E2C0156 for ; Wed, 24 Aug 2016 09:22:22 +0000 (UTC) Date: Wed, 24 Aug 2016 09:22:22 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (HBASE-16456) Fix findbugs warnings in hbase-rsgroup module MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 24 Aug 2016 09:22:23 -0000 [ https://issues.apache.org/jira/browse/HBASE-16456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu reassigned HBASE-16456: ------------------------------ Assignee: Guangxu Cheng > Fix findbugs warnings in hbase-rsgroup module > --------------------------------------------- > > Key: HBASE-16456 > URL: https://issues.apache.org/jira/browse/HBASE-16456 > Project: HBase > Issue Type: Bug > Affects Versions: 2.0.0 > Reporter: Ted Yu > Assignee: Guangxu Cheng > Priority: Minor > Attachments: HBASE-16456-v1.patch, HBASE-16456-v2.patch, findbugs-rsgroup.html > > > https://builds.apache.org/job/PreCommit-HBASE-Build/3161/artifact/patchprocess/branch-findbugs-hbase-rsgroup-warnings.html : > Multithreaded correctness Warnings > Code Warning > SC new org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl(MasterServices) invokes org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.start() > SWL org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveServers(Set, String) calls Thread.sleep() with a lock held > Performance Warnings > Code Warning > WMI org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.correctAssignments(Map) makes inefficient use of keySet iterator instead of entrySet iterator > WMI org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.getMisplacedRegions(Map) makes inefficient use of keySet iterator instead of entrySet iterator > Dodgy code Warnings > Code Warning > REC Exception is caught when Exception is not thrown in org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.waitForGroupTableOnline() > ST Write to static field org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.groupInfoManager from instance method org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.start(CoprocessorEnvironment) -- This message was sent by Atlassian JIRA (v6.3.4#6332)