Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4BB06200B78 for ; Fri, 19 Aug 2016 00:00:24 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4A415160AB7; Thu, 18 Aug 2016 22:00:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B551A160A86 for ; Fri, 19 Aug 2016 00:00:23 +0200 (CEST) Received: (qmail 90232 invoked by uid 500); 18 Aug 2016 22:00:22 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 90212 invoked by uid 99); 18 Aug 2016 22:00:22 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Aug 2016 22:00:22 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id B35AE2C02A1 for ; Thu, 18 Aug 2016 22:00:22 +0000 (UTC) Date: Thu, 18 Aug 2016 22:00:22 +0000 (UTC) From: "Geoffrey Jacoby (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-16448) Custom metrics for custom replication endpoints MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 18 Aug 2016 22:00:24 -0000 [ https://issues.apache.org/jira/browse/HBASE-16448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoffrey Jacoby updated HBASE-16448: ------------------------------------ Status: Patch Available (was: Open) Made MetricsSource a decorator for the BaseSource implementation it already wrapped. > Custom metrics for custom replication endpoints > ----------------------------------------------- > > Key: HBASE-16448 > URL: https://issues.apache.org/jira/browse/HBASE-16448 > Project: HBase > Issue Type: Improvement > Components: Replication > Affects Versions: 0.98.21, 1.2.2, 2.0.0 > Reporter: Geoffrey Jacoby > Assignee: Geoffrey Jacoby > Attachments: HBASE-16448.patch > > > ReplicationEndpoints contain a MetricsSource class that can update a fixed set of key replication metrics. It does not, however, allow a developer implementing a custom ReplicationEndpoint to create/update custom metrics unique to the new endpoint's use case. > As it turns out, MetricsSource wraps a class, which in turn wraps a class, that implements the Hadoop BaseSource interface, which does allow for custom metrics. Simply having the two wrappers implement BaseSource as well with pass-through methods should be straightforward, and would allow replication endpoints to use these generic metric methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)