Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9EDA6200B7A for ; Mon, 22 Aug 2016 06:28:18 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9D7EA160AC0; Mon, 22 Aug 2016 04:28:18 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 184BC160AC2 for ; Mon, 22 Aug 2016 06:28:17 +0200 (CEST) Received: (qmail 47384 invoked by uid 500); 22 Aug 2016 04:24:21 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 44907 invoked by uid 99); 22 Aug 2016 04:20:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Aug 2016 04:20:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 9E4F92C0155 for ; Mon, 22 Aug 2016 04:20:20 +0000 (UTC) Date: Mon, 22 Aug 2016 04:20:20 +0000 (UTC) From: "ramkrishna.s.vasudevan (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-16444) CellUtil#getSumOfCellKeyElementLengths() should consider KEY_INFRASTRUCTURE_SIZE MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 22 Aug 2016 04:28:18 -0000 [ https://issues.apache.org/jira/browse/HBASE-16444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-16444: ------------------------------------------- Attachment: HBASE-16444.patch A simple patch. Will try QA. > CellUtil#getSumOfCellKeyElementLengths() should consider KEY_INFRASTRUCTURE_SIZE > -------------------------------------------------------------------------------- > > Key: HBASE-16444 > URL: https://issues.apache.org/jira/browse/HBASE-16444 > Project: HBase > Issue Type: Bug > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Priority: Minor > Attachments: HBASE-16444.patch > > > Currently CellUtil#getSumOfCellKeyElementLengths() considers > {code} > return cell.getRowLength() + cell.getFamilyLength() + > cell.getQualifierLength() + > KeyValue.TIMESTAMP_TYPE_SIZE; > {code} > It can consider the 2 byte ROWLEN and 1 byte FAMILY_LEN also because with the current way of things we are sure how our key is structured. > But pls note that > {code} > // This will be a low estimate. Will do for now. > return getSumOfCellKeyElementLengths(cell); > {code} > It says clearly it is going to be a low estimate. But in the write path there should be no harm in adding the complete KEY_INFRA_SIZE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)