Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 22 Aug 2016 07:37:21 +0000 (UTC)
From: "Duo Zhang (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12997826.1471418203000.367373.1471851441538@Atlassian.JIRA>
In-Reply-To: <JIRA.12997826.1471418203000@Atlassian.JIRA>
References: <JIRA.12997826.1471418203000@Atlassian.JIRA> <JIRA.12997826.1471418203361@arcas>
Subject: [jira] [Commented] (HBASE-16433) Remove AsyncRpcChannel related
 stuffs
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 22 Aug 2016 07:37:23 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430250#comment-15430250 ] 

Duo Zhang commented on HBASE-16433:
-----------------------------------

And I think we have already reached an agreement that the netty stuffs should not be exposed to user level API. And for {{CompletableFuture}}, there are also lot of extra objection allocations since you will get a new {{CompletableFuture}} every time when you do chaining.

And to be honest, I do not think a little more object allocations is a big problem for a simple ping-pong RPC call as there are already bunch of object allocations during an RPC call and the cost of creating an RpcController is really cheap.

Thanks.

> Remove AsyncRpcChannel related stuffs
> -------------------------------------
>
>                 Key: HBASE-16433
>                 URL: https://issues.apache.org/jira/browse/HBASE-16433
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16433.patch
>
>
> AsyncRpcChannel can not be used by protobuf stub. We should implement the async logic along with the RpcChannel interface of protobuf.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)