Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 12 Aug 2016 04:52:20 +0000 (UTC)
From: "Andrew Purtell (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12996801.1470959932000.289243.1470977540613@Atlassian.JIRA>
In-Reply-To: <JIRA.12996801.1470959932000@Atlassian.JIRA>
References: <JIRA.12996801.1470959932000@Atlassian.JIRA> <JIRA.12996801.1470959932990@arcas>
Subject: [jira] [Commented] (HBASE-16402) RegionServerCoprocessorHost should
 be initialized before RpcServer starts
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 12 Aug 2016 04:52:22 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418366#comment-15418366 ] 

Andrew Purtell commented on HBASE-16402:
----------------------------------------

Pushed

> RegionServerCoprocessorHost should be initialized before RpcServer starts
> -------------------------------------------------------------------------
>
>                 Key: HBASE-16402
>                 URL: https://issues.apache.org/jira/browse/HBASE-16402
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>             Fix For: 0.98.22
>
>         Attachments: HBASE-16402-0.98.patch
>
>
> We found NPE in our 0.98 production cluster because RegionServerCoprocessorHost is not initialized before RpcServer start service.
> {code}
>       // Try and register with the Master; tell it we are here.  Break if
>       // server is stopped or the clusterup flag is down or hdfs went wacky.
>       while (keepLooping()) {
>         RegionServerStartupResponse w = reportForDuty();
>         if (w == null) {
>           LOG.warn("reportForDuty failed; sleeping and then retrying.");
>           this.sleeper.sleep();
>         } else {
>           handleReportForDutyResponse(w);
>           break;
>         }
>       }
>       // Initialize the RegionServerCoprocessorHost now that our ephemeral
>       // node was created by reportForDuty, in case any coprocessors want
>       // to use ZooKeeper
>       this.rsHost = new RegionServerCoprocessorHost(this, this.conf);
> {code}
> RpcServer start service in handleReportForDutyResponse(), then it can serve rpc call replicateWALEntry(). But the RegionServerCoprocessorHost is not initialized and it is used in replicateWALEntry, so it will throw a NPE.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)