Return-Path: <issues-return-255578-archive-asf-public=cust-asf.ponee.io@hbase.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 9EA50200B67
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Tue, 16 Aug 2016 12:06:23 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 9D70F160A76; Tue, 16 Aug 2016 10:06:23 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 214A9160AA8
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 16 Aug 2016 12:06:22 +0200 (CEST)
Received: (qmail 87407 invoked by uid 500); 16 Aug 2016 10:06:21 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 86770 invoked by uid 99); 16 Aug 2016 10:06:21 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Aug 2016 10:06:21 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 909722C02AC
	for <issues@hbase.apache.org>; Tue, 16 Aug 2016 10:06:20 +0000 (UTC)
Date: Tue, 16 Aug 2016 10:06:20 +0000 (UTC)
From: "ChiaPing Tsai (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12994528.1470215928000.315398.1471341980589@Atlassian.JIRA>
In-Reply-To: <JIRA.12994528.1470215928000@Atlassian.JIRA>
References: <JIRA.12994528.1470215928000@Atlassian.JIRA> <JIRA.12994528.1470215928361@arcas>
Subject: [jira] [Updated] (HBASE-16346) The addColumn() method of INCREMENT
 does not accept null qualifier
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Tue, 16 Aug 2016 10:06:23 -0000


     [ https://issues.apache.org/jira/browse/HBASE-16346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ChiaPing Tsai updated HBASE-16346:
----------------------------------
    Attachment: HBASE-16346.v0.patch

all failed tests are passed locally

> The addColumn() method of INCREMENT does not accept null qualifier
> ------------------------------------------------------------------
>
>                 Key: HBASE-16346
>                 URL: https://issues.apache.org/jira/browse/HBASE-16346
>             Project: HBase
>          Issue Type: Bug
>            Reporter: ChiaPing Tsai
>            Assignee: ChiaPing Tsai
>            Priority: Trivial
>         Attachments: HBASE-16346-v0.txt, HBASE-16346.v0.patch
>
>
> {code:title=Increment.java|borderStyle=solid}
>  // Is it necessary to prevent the null qualifier
>   public Increment addColumn(byte [] family, byte [] qualifier, long amount) {
>     if (family == null) {
>       throw new IllegalArgumentException("family cannot be null");
>     }
>     if (qualifier == null) {
>       throw new IllegalArgumentException("qualifier cannot be null");
>     }
>     List<Cell> list = getCellList(family);
>     KeyValue kv = createPutKeyValue(family, qualifier, ts, Bytes.toBytes(amount));
>     list.add(kv);
>     familyMap.put(CellUtil.cloneFamily(kv), list);
>     return this;
>   }
> {code}
> I use the add(Cell) method to add the cell with null qualifier and it works fine.
> It seems to me that the check should be removed
> any command? thanks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)