Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3B198200B81 for ; Sat, 6 Aug 2016 00:56:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 39EEF160AAC; Fri, 5 Aug 2016 22:56:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8162A160A8E for ; Sat, 6 Aug 2016 00:56:22 +0200 (CEST) Received: (qmail 89085 invoked by uid 500); 5 Aug 2016 22:56:21 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 88757 invoked by uid 99); 5 Aug 2016 22:56:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Aug 2016 22:56:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id E55CB2C0D5F for ; Fri, 5 Aug 2016 22:56:20 +0000 (UTC) Date: Fri, 5 Aug 2016 22:56:20 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 05 Aug 2016 22:56:23 -0000 [ https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410250#comment-15410250 ] Hudson commented on HBASE-16303: -------------------------------- SUCCESS: Integrated in HBase-1.3-IT #782 (See [https://builds.apache.org/job/HBase-1.3-IT/782/]) Revert "HBASE-16303 Addendum as the wrong patch was committed" (busbey: rev 76658440dfaddde890a216c8247855182a6c9ac5) * hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java > FilterList with MUST_PASS_ONE optimization > ------------------------------------------ > > Key: HBASE-16303 > URL: https://issues.apache.org/jira/browse/HBASE-16303 > Project: HBase > Issue Type: Bug > Components: Filters > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-16303.patch, HBASE-16303.patch, HBASE-16303_1.patch, HBASE-16303_1.patch > > > This JIRA was created to add @Test tag for all the filter related tests. After doing that one such test failed in TestFilterList#testFilterListTwoFiltersMustPassOne. > The test assumes that when a PrefixFilter is added to a filterlist once the given prefix is passed we should SKIP all other rows. But the impl in FilterList for MUST_PASS_ONE filter is such that once the filter in the list sees that filterAllRemaining is true we don't use that to decide if to to SEE_NEXT_USING_HINT or not. This patch tries to handle that case where if for a filter FilterAllRemaining is true then SEEK_NEXT_USING_HINT need not be done. -- This message was sent by Atlassian JIRA (v6.3.4#6332)