Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6B50E200B63 for ; Mon, 1 Aug 2016 05:34:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 69CCC160AA9; Mon, 1 Aug 2016 03:34:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D77DD160A81 for ; Mon, 1 Aug 2016 05:34:22 +0200 (CEST) Received: (qmail 13454 invoked by uid 500); 1 Aug 2016 03:34:21 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 12936 invoked by uid 99); 1 Aug 2016 03:34:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Aug 2016 03:34:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id F1BC62C0E48 for ; Mon, 1 Aug 2016 03:34:20 +0000 (UTC) Date: Mon, 1 Aug 2016 03:34:20 +0000 (UTC) From: "Duo Zhang (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-16225) Refactor ScanQueryMatcher MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 01 Aug 2016 03:34:23 -0000 [ https://issues.apache.org/jira/browse/HBASE-16225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-16225: ------------------------------ Attachment: (was: HBASE-16225-branch-1-v1.patch) > Refactor ScanQueryMatcher > ------------------------- > > Key: HBASE-16225 > URL: https://issues.apache.org/jira/browse/HBASE-16225 > Project: HBase > Issue Type: Improvement > Reporter: Duo Zhang > Assignee: Duo Zhang > Attachments: HBASE-16225-branch-1.patch, HBASE-16225-v1.patch, HBASE-16225-v2.patch, HBASE-16225-v3.patch, HBASE-16225-v4.patch, HBASE-16225-v5.patch, HBASE-16225-v6.patch, HBASE-16225.patch > > > As said in HBASE-16223, the code of {{ScanQueryMatcher}} is too complicated. I suggest that we can abstract an interface and implement several sub classes which separate different logic into different implementations. For example, the requirements of compaction and user scan are different, now we also need to consider the logic of user scan even if we only want to add a logic for compaction. And at least, the raw scan does not need a query matcher... we can implement a dummy query matcher for it. > Suggestions are welcomed. Thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)