Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DA8C1200B5B for ; Fri, 5 Aug 2016 22:55:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D9300160A8E; Fri, 5 Aug 2016 20:55:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 302AF160A64 for ; Fri, 5 Aug 2016 22:55:22 +0200 (CEST) Received: (qmail 692 invoked by uid 500); 5 Aug 2016 20:55:20 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 670 invoked by uid 99); 5 Aug 2016 20:55:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Aug 2016 20:55:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 8C7C42C0D62 for ; Fri, 5 Aug 2016 20:55:20 +0000 (UTC) Date: Fri, 5 Aug 2016 20:55:20 +0000 (UTC) From: "Sean Busbey (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (HBASE-8386) deprecate TableMapReduce.addDependencyJars(Configuration, class ...) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 05 Aug 2016 20:55:23 -0000 [ https://issues.apache.org/jira/browse/HBASE-8386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey resolved HBASE-8386. -------------------------------- Resolution: Fixed Release Note: The MapReduce helper function `TableMapReduce.addDependencyJars(Configuration, class ...)` has been deprecated since it is easy to use incorrectly. Most users should rely on addDependencyJars(Job) instead. > deprecate TableMapReduce.addDependencyJars(Configuration, class ...) > ----------------------------------------------------------------------- > > Key: HBASE-8386 > URL: https://issues.apache.org/jira/browse/HBASE-8386 > Project: HBase > Issue Type: Improvement > Components: mapreduce > Reporter: Nick Dimiduk > Assignee: Sean Busbey > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-8386.1.patch > > > We expose two public static methods names {{addDependencyJars}}. One of them, {{void addDependencyJars(Job}}, is very helpful -- goes out of its way to detect job dependencies as well as shipping all the necessary HBase dependencies. The other is shfty and nefarious, {{void addDependencyJars(Configuration, Class...)}} -- it only adds exactly what the user requests, forcing them to resolve dependencies themselves and giving a false sense of security. We should deprecate the latter throw a big giant warning when people use that one. The handy functionality of providing help when our heuristics fail can be added via a new method signature, something like {{void addDependencyJars(Job, Class ...}}. This method would do everything {{void addDependencyJars(Job}} does, plus let the user specify arbitrary additional classes. That way HBase still can help the user, but also gives them super-powers to compensate for when our heuristics fail. > For reference, this appears to be the reason why HBase + Pig doesn't really work out of the box. See [HBaseStorage.java|https://github.com/apache/pig/blob/trunk/src/org/apache/pig/backend/hadoop/hbase/HBaseStorage.java#L730] -- This message was sent by Atlassian JIRA (v6.3.4#6332)