hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16530) Reduce DBE code duplication
Date Wed, 31 Aug 2016 08:40:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15451605#comment-15451605
] 

ramkrishna.s.vasudevan commented on HBASE-16530:
------------------------------------------------

Mark IA.Private for this AbstractDataBlockEncoder .
Do we need this 'NoDataBlockEncoderUtil'? It is also missing IA.Private annotation.
Can we add a static method in ByteBufferedDataEncoder/AbstractByteBufferedDataEncoder itself
and call that from the 3 algo implementations? 
Some more code duplicates were there reg the tag compression and tag encoding and decoding?
 I remember seeing that. May be it is corrected now in the last commits?


> Reduce DBE code duplication
> ---------------------------
>
>                 Key: HBASE-16530
>                 URL: https://issues.apache.org/jira/browse/HBASE-16530
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Performance
>            Reporter: binlijin
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-16530-master_V1.patch, HBASE-16530-master_V2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message