hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16512) when locate meta region, we should respect the param "useCache" passed in on 0.98
Date Mon, 29 Aug 2016 07:29:22 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15445098#comment-15445098
] 

Hadoop QA commented on HBASE-16512:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {color} | {color:blue}
Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s {color} | {color:red}
HBASE-16512 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.3.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12825961/HBASE-16512_0.98.patch
|
| JIRA Issue | HBASE-16512 |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/3306/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> when locate meta region, we should respect the param "useCache" passed in on 0.98
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-16512
>                 URL: https://issues.apache.org/jira/browse/HBASE-16512
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.21
>            Reporter: Heng Chen
>             Fix For: 0.98.22
>
>         Attachments: HBASE-16512_0.98.patch
>
>
> we found that when RS with meta crash,  client will retry the same request,  but it still
use the original meta location in cache, so all request retried will failed. 
> Notice the code in HConnectionMananger#locateRegionInMeta,  the "useCache" passed in
is not used when try to found the meta region. 
> {code}
>     private HRegionLocation locateRegionInMeta(final TableName parentTable,
>       final TableName tableName, final byte [] row, boolean useCache,
>       Object regionLockObject, boolean retry)
>     throws IOException {
>       ......
>       for (int tries = 0; true; tries++) {
>        .....
>         HRegionLocation metaLocation = null;
>         try {
>           // locate the meta region
>           metaLocation = locateRegion(parentTable, metaKey, true, false); //NOTICE: we
should honor the "useCache" passed in when locate the meta region.
>           ....
>       }
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message