hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16448) Custom metrics for custom replication endpoints
Date Wed, 24 Aug 2016 12:49:22 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434870#comment-15434870
] 

Hudson commented on HBASE-16448:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-0.98-matrix #391 (See [https://builds.apache.org/job/HBase-0.98-matrix/391/])
HBASE-16448 Custom metrics for custom replication endpoints (apurtell: rev aac4e09514b8b7dcf9d253d5722d0fe813973b99)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsSource.java
* (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSourceImpl.java
* (edit) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSource.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationEndpoint.java
* (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSource.java


> Custom metrics for custom replication endpoints
> -----------------------------------------------
>
>                 Key: HBASE-16448
>                 URL: https://issues.apache.org/jira/browse/HBASE-16448
>             Project: HBase
>          Issue Type: Improvement
>          Components: Replication
>    Affects Versions: 2.0.0, 1.2.2, 0.98.21
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>             Fix For: 2.0.0, 1.4.0, 0.98.22
>
>         Attachments: HBASE-16448-0.98.patch, HBASE-16448-branch-1.patch, HBASE-16448.patch
>
>
> ReplicationEndpoints contain a MetricsSource class that can update a fixed set of key
replication metrics. It does not, however, allow a developer implementing a custom ReplicationEndpoint
to create/update custom metrics unique to the new endpoint's use case. 
> As it turns out, MetricsSource wraps a class, which in turn wraps a class, that implements
the Hadoop BaseSource interface, which does allow for custom metrics. Simply having the two
wrappers implement BaseSource as well with pass-through methods should be straightforward,
and would allow replication endpoints to use these generic metric methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message