hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geoffrey Jacoby (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16448) Custom metrics for custom replication endpoints
Date Fri, 19 Aug 2016 20:53:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428790#comment-15428790
] 

Geoffrey Jacoby commented on HBASE-16448:
-----------------------------------------

[~apurtell] - Adding the interface annotation requires adding dependencies on hadoop-annotation
and hbase-common libraries to hbase-hadoop-compat. Is this acceptable or does that mess up
the design of the dependency tree? I know this has to work on multiple hadoop version profiles.


> Custom metrics for custom replication endpoints
> -----------------------------------------------
>
>                 Key: HBASE-16448
>                 URL: https://issues.apache.org/jira/browse/HBASE-16448
>             Project: HBase
>          Issue Type: Improvement
>          Components: Replication
>    Affects Versions: 2.0.0, 1.2.2, 0.98.21
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>         Attachments: HBASE-16448.patch
>
>
> ReplicationEndpoints contain a MetricsSource class that can update a fixed set of key
replication metrics. It does not, however, allow a developer implementing a custom ReplicationEndpoint
to create/update custom metrics unique to the new endpoint's use case. 
> As it turns out, MetricsSource wraps a class, which in turn wraps a class, that implements
the Hadoop BaseSource interface, which does allow for custom metrics. Simply having the two
wrappers implement BaseSource as well with pass-through methods should be straightforward,
and would allow replication endpoints to use these generic metric methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message