hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16445) Refactor and reimplement RpcClient
Date Mon, 29 Aug 2016 13:21:21 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15445865#comment-15445865
] 

Hadoop QA commented on HBASE-16445:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s {color} | {color:blue}
Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green}
The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color}
| {color:green} The patch appears to include 10 new or modified test files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 18s {color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 6s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 46s {color} |
{color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 53s {color} |
{color:green} master passed with JDK v1.7.0_111 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 48s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 27s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 56s {color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 41s {color} |
{color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 55s {color} |
{color:green} master passed with JDK v1.7.0_111 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s {color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 6s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 45s {color} |
{color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 45s {color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 53s {color} |
{color:green} the patch passed with JDK v1.7.0_111 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 53s {color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 47s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 28s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m 24s {color} | {color:red}
The patch causes 18 errors with Hadoop v2.4.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m 47s {color} | {color:red}
The patch causes 18 errors with Hadoop v2.4.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m 14s {color} | {color:red}
The patch causes 18 errors with Hadoop v2.5.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m 39s {color} | {color:red}
The patch causes 18 errors with Hadoop v2.5.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 7m 5s {color} | {color:red}
The patch causes 18 errors with Hadoop v2.5.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 8m 32s {color} | {color:red}
The patch causes 18 errors with Hadoop v2.6.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 9m 57s {color} | {color:red}
The patch causes 18 errors with Hadoop v2.6.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 11m 23s {color} | {color:red}
The patch causes 18 errors with Hadoop v2.6.3. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 12m 50s {color} | {color:red}
The patch causes 18 errors with Hadoop v2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 26s {color}
| {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 11s {color} | {color:red}
hbase-client generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 15s {color} | {color:red}
hbase-client-jdk1.8.0_101 with JDK v1.8.0_101 generated 1 new + 14 unchanged - 0 fixed = 15
total (was 14) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 19s {color} | {color:red}
hbase-client-jdk1.7.0_111 with JDK v1.7.0_111 generated 1 new + 14 unchanged - 0 fixed = 15
total (was 14) {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 0s {color} | {color:green}
hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 126m 24s {color} | {color:red}
hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 35s {color} | {color:red}
The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 162m 22s {color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-client |
|  |  Inconsistent synchronization of org.apache.hadoop.hbase.ipc.Call.error; locked 40% of
time  Unsynchronized access at AbstractRpcClient.java:40% of time  Unsynchronized access at
AbstractRpcClient.java:[line 344] |
|  |  Inconsistent synchronization of org.apache.hadoop.hbase.ipc.Call.response; locked 50%
of time  Unsynchronized access at AbstractRpcClient.java:50% of time  Unsynchronized access
at AbstractRpcClient.java:[line 351] |
|  |  Inconsistent synchronization of org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController.cancelled;
locked 80% of time  Unsynchronized access at PayloadCarryingRpcController.java:80% of time
 Unsynchronized access at PayloadCarryingRpcController.java:[line 121] |
|  |  Inconsistent synchronization of org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController.done;
locked 90% of time  Unsynchronized access at PayloadCarryingRpcController.java:90% of time
 Unsynchronized access at PayloadCarryingRpcController.java:[line 120] |
|  |  Inconsistent synchronization of org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController.exception;
locked 85% of time  Unsynchronized access at PayloadCarryingRpcController.java:85% of time
 Unsynchronized access at PayloadCarryingRpcController.java:[line 119] |
| Failed junit tests | hadoop.hbase.master.TestAssignmentManagerOnCluster |
|   | hadoop.hbase.security.token.TestTokenAuthentication |
|   | hadoop.hbase.security.token.TestGenerateDelegationToken |
|   | hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService |
|   | hadoop.hbase.master.TestMasterOperationsForRegionReplicas |
|   | hadoop.hbase.security.token.TestDelegationTokenWithEncryption |
|   | hadoop.hbase.coprocessor.TestCoprocessorEndpoint |
|   | hadoop.hbase.util.TestHBaseFsckOneRS |
|   | hadoop.hbase.master.procedure.TestServerCrashProcedure |
|   | hadoop.hbase.regionserver.TestRegionReplicas |
|   | hadoop.hbase.security.visibility.TestVisibilityLabelsWithSLGStack |
|   | hadoop.hbase.client.TestRpcControllerFactory |
|   | hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures |
|   | hadoop.hbase.security.visibility.TestDefaultScanLabelGeneratorStack |
|   | hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL |
|   | hadoop.hbase.security.visibility.TestWithDisabledAuthorization |
|   | hadoop.hbase.coprocessor.TestRegionServerCoprocessorEndpoint |
|   | hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService |
|   | hadoop.hbase.regionserver.TestRegionReplicaFailover |
|   | hadoop.hbase.security.visibility.TestVisibilityLabelsReplication |
|   | hadoop.hbase.util.TestHBaseFsckTwoRS |
|   | hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels |
|   | hadoop.hbase.regionserver.TestEncryptionKeyRotation |
| Timed out junit tests | org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoadWithOldSecureEndpoint
|
|   | org.apache.hadoop.hbase.coprocessor.TestAggregateProtocol |
|   | org.apache.hadoop.hbase.coprocessor.TestBigDecimalColumnInterpreter |
|   | org.apache.hadoop.hbase.coprocessor.TestDoubleColumnInterpreter |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2016-08-29 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12825989/HBASE-16445.patch
|
| JIRA Issue | HBASE-16445 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  hbaseanti  checkstyle
 compile  |
| uname | Linux 80bef31d9e3f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12
UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 950d547 |
| Default Java | 1.7.0_111 |
| Multi-JDK versions |  /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
|
| findbugs | v3.0.0 |
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/3308/artifact/patchprocess/new-findbugs-hbase-client.html
|
| javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/3308/artifact/patchprocess/diff-javadoc-javadoc-hbase-client-jdk1.8.0_101.txt
|
| javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/3308/artifact/patchprocess/diff-javadoc-javadoc-hbase-client-jdk1.7.0_111.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/3308/artifact/patchprocess/patch-unit-hbase-server.txt
|
| unit test logs |  https://builds.apache.org/job/PreCommit-HBASE-Build/3308/artifact/patchprocess/patch-unit-hbase-server.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/3308/testReport/ |
| asflicense | https://builds.apache.org/job/PreCommit-HBASE-Build/3308/artifact/patchprocess/patch-asflicense-problems.txt
|
| modules | C: hbase-client hbase-server U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/3308/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> Refactor and reimplement RpcClient
> ----------------------------------
>
>                 Key: HBASE-16445
>                 URL: https://issues.apache.org/jira/browse/HBASE-16445
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16445.patch
>
>
> There are lots of common logics between RpcClientImpl and AsyncRpcClient. We should have
much less code comparing to the current implementations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message