hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16444) CellUtil#getSumOfCellKeyElementLengths() should consider KEY_INFRASTRUCTURE_SIZE
Date Thu, 18 Aug 2016 07:30:23 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15426023#comment-15426023
] 

Anoop Sam John commented on HBASE-16444:
----------------------------------------

Wherever this path is used (estimated*** methods) there is a KeyValue type check and if so,
we calc the correct size which will be adding the KEY_INFRASTRUCTURE_SIZE.  So in these methods
no need to add it as we dont know what kind of cell it is. IMO there is no need for  a change.
 What is the implication if not added?

> CellUtil#getSumOfCellKeyElementLengths() should consider KEY_INFRASTRUCTURE_SIZE
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-16444
>                 URL: https://issues.apache.org/jira/browse/HBASE-16444
>             Project: HBase
>          Issue Type: Bug
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>
> Currently CellUtil#getSumOfCellKeyElementLengths() considers 
> {code}
>     return cell.getRowLength() + cell.getFamilyLength() +
>     cell.getQualifierLength() +
>     KeyValue.TIMESTAMP_TYPE_SIZE;
> {code}
> It can consider the 2 byte ROWLEN and 1 byte FAMILY_LEN also because with the current
way of things we are sure how our key is structured.
> But pls note that
> {code}
>     // This will be a low estimate.  Will do for now.
>     return getSumOfCellKeyElementLengths(cell);
> {code}
> It says clearly it is going to be a low estimate. But in the write path there should
be no harm in adding the complete KEY_INFRA_SIZE. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message