hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jurriaan Mous (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16433) Remove AsyncRpcChannel related stuffs
Date Mon, 22 Aug 2016 07:43:21 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430252#comment-15430252

Jurriaan Mous commented on HBASE-16433:

{quote} I do not think this will fail at compile time if the proto file is changed. And also,
you can call the get method with a protobuf message with any type and does not cause any compile
error. I do not think this a good practice.{quote}

Ah yes. I was looking a bit too much into interface forgetting how I got them. 

We could also hardlink them to the generated code by depending on org.apache.hadoop.hbase.protobuf.generated.ClientProtos.Get.class.getSimpleName().

> Remove AsyncRpcChannel related stuffs
> -------------------------------------
>                 Key: HBASE-16433
>                 URL: https://issues.apache.org/jira/browse/HBASE-16433
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>         Attachments: HBASE-16433.patch
> AsyncRpcChannel can not be used by protobuf stub. We should implement the async logic
along with the RpcChannel interface of protobuf.

This message was sent by Atlassian JIRA

View raw message