hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16433) Remove AsyncRpcChannel related stuffs
Date Thu, 18 Aug 2016 00:15:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425638#comment-15425638
] 

Duo Zhang commented on HBASE-16433:
-----------------------------------

I agree that the protobuf stub is not a good abstraction of event-driven code, but I do not
think it is a good idea to partially bypass it. The string name mapping in the protobuf code
is generated by protoc, so it is much safer than our hand-written mapping code. None or all,
my suggestion. We should either implement our code on the suck but work stub, or change to
use something new such as grpc as our RPC layer.

Thanks.

> Remove AsyncRpcChannel related stuffs
> -------------------------------------
>
>                 Key: HBASE-16433
>                 URL: https://issues.apache.org/jira/browse/HBASE-16433
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16433.patch
>
>
> AsyncRpcChannel can not be used by protobuf stub. We should implement the async logic
along with the RpcChannel interface of protobuf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message