hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16433) Remove AsyncRpcChannel related stuffs
Date Thu, 18 Aug 2016 00:06:23 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425628#comment-15425628
] 

Duo Zhang commented on HBASE-16433:
-----------------------------------

On a mobile phone so reply all things here, include the questions on RB.

The parameter type in protobuf stub is the actual type of request and in the general call
method it is Message, so this means we can not find the error at compile time. And for the
RpcController, I do not think the 'possible null' is a problem if the upper layer need it
to receive something. For exapmle, I think we will always have a pcrc when doing scan because
we need it to get the CellScanner, otherwise the logic is broken. For AsyncTable implementation,
you always need a pcrc to check if we are in error.

> Remove AsyncRpcChannel related stuffs
> -------------------------------------
>
>                 Key: HBASE-16433
>                 URL: https://issues.apache.org/jira/browse/HBASE-16433
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16433.patch
>
>
> AsyncRpcChannel can not be used by protobuf stub. We should implement the async logic
along with the RpcChannel interface of protobuf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message